Add open for composed transcodingstreams#113
Open
jakobnissen wants to merge 2 commits intoJuliaIO:masterfrom
Open
Add open for composed transcodingstreams#113jakobnissen wants to merge 2 commits intoJuliaIO:masterfrom
jakobnissen wants to merge 2 commits intoJuliaIO:masterfrom
Conversation
Collaborator
Author
|
I'll add tests if anyone with the permission to merge gives me the thumbs-up :) |
mkitti
reviewed
Aug 23, 2022
Comment on lines
+208
to
+210
| function _open(code::Type{<:Type{T}}, io::IO) where {T <: TranscodingStream} | ||
| T(io) | ||
| end |
Member
There was a problem hiding this comment.
Could you add a comment about what this does?
Member
|
@jakobnissen If helpful and if you are interested, I can give you commit access here. |
Member
|
This still needs a test. |
Member
Agree. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows users to easily chain codecs using the do-syntax. Here is an example where the input is chained through four different streams.