Clean up Rect set operations (union, intersect, diff, overlaps)#276
Draft
Clean up Rect set operations (union, intersect, diff, overlaps)#276
Conversation
Collaborator
Author
|
https://en.wikipedia.org/wiki/Allen%27s_interval_algebra GeometryBasics.jl/src/primitives/rectangles.jl Lines 441 to 486 in 9918b18 This stuff makes sense for intervals but I fail to see how this should generalize to rectangles. For examples saying one interval is or other rotations. Also, for the edge versions, do widths need to match for the dimension that doesn't meet? This doesn't seem clear enough to have. It's been there since the dawn of GeometryTypes 11 years ago |
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
bbox_diff(a, b)which calculates the bounding box of all rects produced by cuttingbout ofa(without calculating those rects).This is something I will probably need for optimizing an SDF
volumeplots in Makie. Doesn't need to be merged/tagged until I get that near completion