Add muladd_scaled and FP8 muladd#239
Open
AntonOresten wants to merge 5 commits into
Open
Conversation
The shape helpers and pack/unpack tfuncs ran inside the kernel-inferred path, where two failure modes produced confusing errors: - A tfunc returning `nothing` on an indivisible width left the result untypable, surfacing downstream as `internal error: invalid terminators`. - A `throw(ArgumentError(...))` in a shape helper became an unsupported `String` in kernel IR (`format_string`/`unsupported String` error), masking the intended message. Make both layers total: pack/unpack tfuncs always return a concrete type (via `fld`), and the shape helpers are pure arithmetic. Validation now lives solely in the pack/unpack/reshape emit, which throws a clear `IRError` (e.g. "unpack: 1 bytes do not evenly divide into Float32"). Valid reinterprets are unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #238
Changes
muladd_scaled(a, a_scale, b, b_scale, acc)functionmuladdfast_acc=truekeyword argument tomuladdmuladdtestsmuladdtestsChecklist
Closes #108 🎉