-
Notifications
You must be signed in to change notification settings - Fork 81
KernelIntrisics and related tweaks #666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
christiangnrd
wants to merge
4
commits into
JuliaGPU:main
Choose a base branch
from
christiangnrd:localmemid
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Your PR requires formatting changes to meet the project's style guidelines. Click here to view the suggested changes.diff --git a/test/intrinsics.jl b/test/intrinsics.jl
index 2c713b5f..63216d32 100644
--- a/test/intrinsics.jl
+++ b/test/intrinsics.jl
@@ -12,12 +12,14 @@ function test_intrinsics_kernel(results)
i = KI.get_global_id().x
if i <= length(results)
- @inbounds results[i] = KernelData(KI.get_global_size().x,
- KI.get_global_id().x,
- KI.get_local_size().x,
- KI.get_local_id().x,
- KI.get_num_groups().x,
- KI.get_group_id().x)
+ @inbounds results[i] = KernelData(
+ KI.get_global_size().x,
+ KI.get_global_id().x,
+ KI.get_local_size().x,
+ KI.get_local_id().x,
+ KI.get_num_groups().x,
+ KI.get_group_id().x
+ )
end
return
end
diff --git a/test/localmem.jl b/test/localmem.jl
index 7894ee61..c1d63c7a 100644
--- a/test/localmem.jl
+++ b/test/localmem.jl
@@ -57,7 +57,7 @@ end
lmem1 = @localmem Int (N,) # Ok iff groupsize is static
lmem2 = @localmem Int (N,) # Ok iff groupsize is static
@inbounds begin
- lmem1[i] = i-1
+ lmem1[i] = i - 1
lmem2[i] = 1
@synchronize
A[I] = lmem1[N2 - i + 1] + lmem2[N2 - i + 1] |
1782c00 to
abc2b1f
Compare
23d6f06 to
1c00d86
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
1c00d86 to
e8983d7
Compare
id argument for KI.localmemoryb21a80c to
12b4d65
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #666 +/- ##
=======================================
Coverage 52.27% 52.27%
=======================================
Files 22 22
Lines 1689 1689
=======================================
Hits 883 883
Misses 806 806 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment was marked as resolved.
This comment was marked as resolved.
12b4d65 to
748f932
Compare
932eb5e to
3dd8c85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was originally to readd the
idargument for shared memory. This may or may not be necessary.