Skip to content

Conversation

@christiangnrd
Copy link
Member

@christiangnrd christiangnrd commented Dec 13, 2025

This PR was originally to readd the id argument for shared memory. This may or may not be necessary.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 13, 2025

Your PR requires formatting changes to meet the project's style guidelines.
Please consider running Runic (git runic main) to apply these changes.

Click here to view the suggested changes.
diff --git a/test/intrinsics.jl b/test/intrinsics.jl
index 2c713b5f..63216d32 100644
--- a/test/intrinsics.jl
+++ b/test/intrinsics.jl
@@ -12,12 +12,14 @@ function test_intrinsics_kernel(results)
     i = KI.get_global_id().x
 
     if i <= length(results)
-        @inbounds results[i] = KernelData(KI.get_global_size().x,
-                                          KI.get_global_id().x,
-                                          KI.get_local_size().x,
-                                          KI.get_local_id().x,
-                                          KI.get_num_groups().x,
-                                          KI.get_group_id().x)
+        @inbounds results[i] = KernelData(
+            KI.get_global_size().x,
+            KI.get_global_id().x,
+            KI.get_local_size().x,
+            KI.get_local_id().x,
+            KI.get_num_groups().x,
+            KI.get_group_id().x
+        )
     end
     return
 end
diff --git a/test/localmem.jl b/test/localmem.jl
index 7894ee61..c1d63c7a 100644
--- a/test/localmem.jl
+++ b/test/localmem.jl
@@ -57,7 +57,7 @@ end
     lmem1 = @localmem Int (N,) # Ok iff groupsize is static
     lmem2 = @localmem Int (N,) # Ok iff groupsize is static
     @inbounds begin
-        lmem1[i] = i-1
+        lmem1[i] = i - 1
         lmem2[i] = 1
         @synchronize
         A[I] = lmem1[N2 - i + 1] + lmem2[N2 - i + 1]

@vchuravy

This comment was marked as resolved.

@christiangnrd

This comment was marked as resolved.

@christiangnrd christiangnrd changed the title Re-add id argument for KI.localmemory KernelIntrisics and related tweaks Dec 15, 2025
@christiangnrd christiangnrd force-pushed the localmemid branch 2 times, most recently from b21a80c to 12b4d65 Compare December 17, 2025 17:55
@codecov
Copy link

codecov bot commented Dec 17, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 52.27%. Comparing base (f716a67) to head (3dd8c85).

Files with missing lines Patch % Lines
src/KernelAbstractions.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #666   +/-   ##
=======================================
  Coverage   52.27%   52.27%           
=======================================
  Files          22       22           
  Lines        1689     1689           
=======================================
  Hits          883      883           
  Misses        806      806           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pxl-th

This comment was marked as resolved.

@christiangnrd christiangnrd requested review from vchuravy and removed request for vchuravy December 22, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants