Extend supports_atomics to include type#595
Extend supports_atomics to include type#595christiangnrd wants to merge 1 commit intoJuliaGPU:mainfrom
supports_atomics to include type#595Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #595 +/- ##
=======================================
Coverage 47.52% 47.52%
=======================================
Files 22 22
Lines 1715 1715
=======================================
Hits 815 815
Misses 900 900 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| """ | ||
| supports_atomics(::Backend)::Bool | ||
| supports_atomics(::Backend, [T::Type{<:Number}])::Bool |
There was a problem hiding this comment.
The long-term goal with moving atomics support to GPUCompiler and legalizing there is that we should also be able to support non-numbers, like Tuple{Int32, Int32}, which makes this query tricky in general.
There was a problem hiding this comment.
Yeah I agree this isn't the best approach. Operation support doesn't just depend on eltype it also depends on the operation itself. Maybe we stick to status quo until someone has the time to come up with a good interface for this api?
See #594