Detect contiguous views with mixed unit-range indices#704
Merged
Conversation
The static `GPUIndexStyle` dispatch couldn't recognize index tuples like
`(1:1, 1:1)` or `(1:5, 2:3, 1:1)` as contiguous because the lengths of
`UnitRange{Int}` aren't visible at the type level. Add a `MaybeContiguous`
tag for `(::AbstractUnitRange, ::AbstractUnitRange, ...)` patterns and a
runtime stride check that decides whether to take the contiguous fast path.
Fixes JuliaGPU/CUDA.jl#2653.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The static
GPUIndexStyledispatch couldn't recognize index tuples like(1:1, 1:1)or(1:5, 2:3, 1:1)as contiguous because the lengths ofUnitRange{Int}aren't visible at the type level. Add aMaybeContiguoustag for(::AbstractUnitRange, ::AbstractUnitRange, ...)patterns and a runtime stride check that decides whether to take the contiguous fast path. Makes things type-unstable, but views being contiguous is much more important, I think.Fixes JuliaGPU/CUDA.jl#2653. cc @kshyatt