Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #744 +/- ##
==========================================
- Coverage 89.57% 86.96% -2.62%
==========================================
Files 11 10 -1
Lines 969 959 -10
==========================================
- Hits 868 834 -34
- Misses 101 125 +24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This is a very welcome initiative to guarantee API stability! So many people have been using ForwardDiff internals that they're not really internals anymore at this point. |
|
Gentle bump on this one |
| eval(Meta.parse( | ||
| "public derivative, derivative!, gradient, gradient!, jacobian, jacobian!, | ||
| hessian, hessian!, DerivativeConfig, GradientConfig, JacobianConfig, HessianConfig")) |
There was a problem hiding this comment.
Maybe a bit more direct:
| eval(Meta.parse( | |
| "public derivative, derivative!, gradient, gradient!, jacobian, jacobian!, | |
| hessian, hessian!, DerivativeConfig, GradientConfig, JacobianConfig, HessianConfig")) | |
| eval(Expr( | |
| :public, | |
| :derivative, | |
| :derivative!, | |
| :gradient, | |
| :gradient!, | |
| :jacobian, | |
| :jacobian!, | |
| :hessian, | |
| :hessian!, | |
| :DerivativeConfig, | |
| :GradientConfig, | |
| :JacobianConfig, | |
| :HessianConfig)) |
There was a problem hiding this comment.
Can we also add:
Chunk
Dual
Tag
checktag
extract_derivative
partials
pickchunksize
valueThose are used in DI so I think it's reasonable for them to be public here.
| eval(Meta.parse( | ||
| "public derivative, derivative!, gradient, gradient!, jacobian, jacobian!, | ||
| hessian, hessian!, DerivativeConfig, GradientConfig, JacobianConfig, HessianConfig")) |
There was a problem hiding this comment.
Can we also add:
Chunk
Dual
Tag
checktag
extract_derivative
partials
pickchunksize
valueThose are used in DI so I think it's reasonable for them to be public here.
First commit adds only those in
api.md, but perhaps we should add more... likeDual?(
evalis following this https://github.com/JuliaLang/julia/pull/55097/files )