Skip to content

fix: make wrong-mode pushforward/pullback return the correct array type#974

Merged
gdalle merged 4 commits intomainfrom
gd/gpu
Mar 4, 2026
Merged

fix: make wrong-mode pushforward/pullback return the correct array type#974
gdalle merged 4 commits intomainfrom
gd/gpu

Conversation

@gdalle
Copy link
Member

@gdalle gdalle commented Mar 4, 2026

With this PR, the iteration over basis vectors still runs on the CPU, which means that the same prep can be reused without race conditions. Conversion is performed at the end to port the data back to the GPU.

@codecov
Copy link

codecov bot commented Mar 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.19%. Comparing base (2b7c5e9) to head (ce5819e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #974      +/-   ##
==========================================
+ Coverage   94.11%   98.19%   +4.08%     
==========================================
  Files         135      135              
  Lines        7980     7999      +19     
==========================================
+ Hits         7510     7855     +345     
+ Misses        470      144     -326     
Flag Coverage Δ
DI 98.96% <100.00%> (+5.67%) ⬆️
DIT 96.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gdalle gdalle marked this pull request as ready for review March 4, 2026 17:38
@gdalle gdalle merged commit 90160b9 into main Mar 4, 2026
68 of 91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant