Skip to content

Conversation

@gdalle
Copy link
Member

@gdalle gdalle commented Dec 9, 2025

Presumably fixes #942

Needs tests

@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

❌ Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.19%. Comparing base (325f2b8) to head (854834d).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ace/ext/DifferentiationInterfaceEnzymeExt/utils.jl 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #943      +/-   ##
==========================================
- Coverage   98.21%   98.19%   -0.03%     
==========================================
  Files         133      133              
  Lines        7976     7981       +5     
==========================================
+ Hits         7834     7837       +3     
- Misses        142      144       +2     
Flag Coverage Δ
DI 98.96% <90.00%> (-0.04%) ⬇️
DIT 96.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timholy
Copy link

timholy commented Dec 11, 2025

For tests, the one-liner in #942 (comment) was able to trigger #942. I just wasn't able to verify that the fixed worked due to other errors thrown after the first one stopped happening.

@gdalle gdalle marked this pull request as ready for review December 18, 2025 09:37
@gdalle
Copy link
Member Author

gdalle commented Dec 18, 2025

Let's merge this, the changes are sound even though Enzyme still errors which prevents proper testing. I'll figure out a pure-Enzyme MWE when I have time

@gdalle gdalle merged commit 45fad0e into main Dec 18, 2025
68 of 69 checks passed
@gdalle gdalle deleted the gd/enzyme_secondorder_functionannot branch December 18, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing _shadow method in Enzyme extension

3 participants