Create Invalidations.yml#64
Closed
ranocha wants to merge 1 commit intoJuliaDiff:masterfrom
ranocha:patch-1
Closed
Conversation
This is based on https://github.com/julia-actions/julia-invalidations. Adding such checks came up in https://discourse.julialang.org/t/potential-performance-regressions-in-julia-1-8-for-special-un-precompiled-type-dispatches-and-how-to-fix-them/86359. I suggest to add this check here since this package is widely used as a dependency. See also SciML/MuladdMacro.jl#26 and SciML/MuladdMacro.jl#29
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #64 +/- ##
==========================================
+ Coverage 83.33% 83.82% +0.49%
==========================================
Files 6 6
Lines 474 476 +2
==========================================
+ Hits 395 399 +4
+ Misses 79 77 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
@ranocha the action seems to error, do you know what's the problem? |
Contributor
Author
|
I hav enever seen that before 🤷 The stacktrace suggests something in |
Member
|
I've seen it in multiple repos but I've never spent time trying to figure why the action is broken in some repos and works in others. |
Member
|
For instance, it errors also in the ForwardDiff repo (JuliaDiff/ForwardDiff.jl#665) and AbstractFFTs (JuliaMath/AbstractFFTs.jl#121). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is based on https://github.com/julia-actions/julia-invalidations. Adding such checks came up in https://discourse.julialang.org/t/potential-performance-regressions-in-julia-1-8-for-special-un-precompiled-type-dispatches-and-how-to-fix-them/86359. I suggest to add this check here since this package is widely used as a dependency.
See also SciML/MuladdMacro.jl#26 and SciML/MuladdMacro.jl#29