Skip to content

Track _defaultctors move from Core to Base #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timholy merged 2 commits into from
Jun 3, 2026
Merged

Track _defaultctors move from Core to Base #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01f79f1
Track _defaultctors move from Core to Base
timholy Jun 3, 2026
1b48085
Test macOS on aarch64 instead of x64
timholy Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@ jobs:
- version: '1' # x64 windows
os: windows-latest
arch: x64
- version: '1' # x64 macOS
- version: '1' # Apple Silicon macOS
os: macos-latest
arch: x64
arch: aarch64
steps:
- uses: actions/checkout@v6
- uses: julia-actions/setup-julia@v3
Expand Down
10 changes: 8 additions & 2 deletions test/codeedges.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,12 @@ function minimal_evaluation(predicate, src::Core.CodeInfo, edges::CodeEdges; kwa
return isrequired
end

# Recognize the default-constructor call emitted when lowering a struct definition.
# `_defaultctors` lived in `Core` through 1.12 but moved to `Base` (JuliaLang/julia, see
# base/essentials.jl), so accept either home.
is_defaultctors_call(@nospecialize stmt) = Meta.isexpr(stmt, :call) &&
(is_global_ref(stmt.args[1], Base, :_defaultctors) || is_global_ref(stmt.args[1], Core, :_defaultctors))

function allmissing(mod::Module, names)
for name in names
isdefined(mod, name) && return false
Expand Down Expand Up @@ -245,7 +251,7 @@ module ModSelective end
isrequired = minimal_evaluation(src, edges) do @nospecialize stmt
# initially mark only the constructor
@static if VERSION ≥ v"1.12-"
return (Meta.isexpr(stmt, :call) && stmt.args[1] == GlobalRef(Core, :_defaultctors), false)
return (is_defaultctors_call(stmt), false)
else
return (LoweredCodeUtils.ismethod_with_name(src, stmt, "NoParam"), false)
end
Expand All @@ -267,7 +273,7 @@ module ModSelective end
isrequired = minimal_evaluation(src, edges) do @nospecialize stmt
# initially mark only the constructor
@static if VERSION ≥ v"1.12-"
return (Meta.isexpr(stmt, :call) && stmt.args[1] == GlobalRef(Core, :_defaultctors), false)
return (is_defaultctors_call(stmt), false)
else
return (LoweredCodeUtils.ismethod_with_name(src, stmt, "Struct"), false)
end
Expand Down
Loading