fix(jh): default to logged in user if username not provided#17
Merged
thelonewolf1603 merged 1 commit intomainfrom Feb 12, 2026
Merged
fix(jh): default to logged in user if username not provided#17thelonewolf1603 merged 1 commit intomainfrom
thelonewolf1603 merged 1 commit intomainfrom
Conversation
thelonewolf1603
force-pushed
the
nd/clone-default-username
branch
2 times, most recently
from
c0a5fd8 to
361f370
Compare
vdayanand
requested changes
Feb 6, 2026
| return fmt.Errorf("failed to get user info for default username: %w", err) | ||
| } | ||
| username = userInfo.Username | ||
| projectName = projectIdentifier |
Member
There was a problem hiding this comment.
projectName = projectIdentifier
Is this intended ? Looks unrelated to PR
Contributor
Author
There was a problem hiding this comment.
its an argument to the function, if you expand above
Member
There was a problem hiding this comment.
but looks like its just assigned and not used anywhere?
Contributor
Author
There was a problem hiding this comment.
the projectName is used right? in line 236
vdayanand
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #5