Skip to content

fix: handle eliminated equations in inline linear SCCs appropriately #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AayushSabharwal merged 1 commit into from
Jun 4, 2026
Merged

fix: handle eliminated equations in inline linear SCCs appropriately #94

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions lib/ModelingToolkitTearing/src/reassemble.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,16 +450,9 @@ function generate_system_equations!(state::TearingState, neweqs::Vector{Equation
linsol, eqs_mask, vars_mask = linsol_result
@assert length(eqs_mask) == length(escc)
@assert length(vars_mask) == length(vscc)
for (i, ieq) in enumerate(escc)
eqs_mask[i] && continue
# Currently, if an equation is filtered out it is matched to a variable.
# This needs to be changed if we update our heuristic.
var = eq_var_matching[ieq]::Int
codegen_equation!(eq_generator, neweqs[ieq], ieq, var; simplify)
end
escc = escc[eqs_mask]
vscc = vscc[vars_mask]
for (j, (ieq, iv)) in enumerate(zip(escc, vscc))
_escc = escc[eqs_mask]
_vscc = vscc[vars_mask]
for (j, (ieq, iv)) in enumerate(zip(_escc, _vscc))
∫iv = diff_to_var[iv]
rhs = linsol[j]
if ∫iv isa Int
Expand All @@ -486,6 +479,16 @@ function generate_system_equations!(state::TearingState, neweqs::Vector{Equation
push!(eq_generator.solved_vars, iv)
end
end

# Add the eliminated equations later so that the preceding loop
# can populate `total_sub` appropriately.
for (i, ieq) in enumerate(escc)
eqs_mask[i] && continue
# Currently, if an equation is filtered out it is matched to a variable.
# This needs to be changed if we update our heuristic.
var = eq_var_matching[ieq]::Int
codegen_equation!(eq_generator, neweqs[ieq], ieq, var; simplify)
end
else
for ieq in escc
iv = eq_var_matching[ieq]
Expand Down
Loading