Don't require the element to be provided to percolate_down! and percolate_up!
#960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
#954 also changed |
Drvi
changed the title
percolate_down!percolate_down! and percolate_up!
devmotion
reviewed
Nov 4, 2025
Member
devmotion
left a comment
devmotion
left a comment
There was a problem hiding this comment.
Seems reasonable to me. Would be good to add a test for this functionality and would require a version bump.
devmotion
approved these changes
Nov 4, 2025
Contributor
Author
|
Thanks for the review! I can't merge the PR, so please, someone do it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #954, which made the third argument, the element (or the Ordering), required. By providing a default value for the Ordering, we no longer hit the edge case.