Restore old printnode behavior for potentially large collections#101
Open
jlumpe wants to merge 1 commit intoJuliaCollections:masterfrom
Open
Restore old printnode behavior for potentially large collections#101jlumpe wants to merge 1 commit intoJuliaCollections:masterfrom
jlumpe wants to merge 1 commit intoJuliaCollections:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #101 +/- ##
==========================================
- Coverage 52.01% 51.87% -0.14%
==========================================
Files 7 7
Lines 373 374 +1
==========================================
Hits 194 194
- Misses 179 180 +1
Continue to review full report at Codecov.
|
Contributor
|
This seems a bit aggressive, there is a huge class of cases in which this will make the display much worse... Perhaps our real problem here is that we use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restoring the old
printnodemethod for potentially large collections (fAbstractArrayandAbstractDict), which just prints the type.