Remove stale version checks and fix soft scope warning#478
Merged
ChrisRackauckas merged 1 commit intoJuliaArrays:masterfrom Feb 9, 2026
Merged
Conversation
- Remove @static if fallback for @assume_effects (available since Julia 1.8, compat requires 1.10+) - Remove VERSION >= v"1.7" guard in test (always true) - Remove VERSION >= v"1.9-" guard in test (always true) - Remove VERSION >= v"1.8-" guard in CUDA extension (always true) - Fix soft scope warning for B variable in bandedmatrices test Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #478 +/- ##
==========================================
+ Coverage 61.13% 61.35% +0.21%
==========================================
Files 13 13
Lines 579 577 -2
==========================================
Hits 354 354
+ Misses 225 223 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@static if isdefined(Base, :@assume_effects)fallback insrc/ArrayInterface.jl—@assume_effectshas been available since Julia 1.8, and compat requires 1.10+VERSION >= v"1.7"guard intest/core.jl(always true, deadVal(true)QR code path)VERSION >= v"1.9-"guard intest/core.jl(always true,cholesky_instancetest now runs unconditionally)VERSION >= v"1.8-"guard inext/ArrayInterfaceCUDAExt.jl(always true, deadlu(A; check=false)fallback)Bvariable intest/bandedmatrices.jlby addinglocal BNo deprecation warnings were found in ArrayInterface.jl or its test dependencies on Julia 1.12.4 (verified with
Pkg.test(; julia_args=["--depwarn=error"])). This PR cleans up stale version-gated code that can never execute given the Julia 1.10+ compat requirement.Test plan
Pkg.test(; julia_args=["--depwarn=error"])🤖 Generated with Claude Code