test: improve watch coverage from 79.9% to 80.4%#48
Open
JordanCoin wants to merge 1 commit intomainfrom
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Improves test coverage for the watch/ package by adding targeted unit tests around event log trimming, event handling, and debouncer behavior, and updates CI’s enforced overall coverage floor accordingly.
Changes:
- Add tests for
trimEventLogToBytesbehavior with invalid limit inputs. - Add tests covering
Daemon.handleEventwrite/remove behavior and gitignore skipping. - Add a test ensuring
newEventDebouncerenforces a minimum prune window; bump CI coverage floor to 50%.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| watch/events_limits_test.go | Adds coverage for trimEventLogToBytes invalid-limit no-op behavior. |
| watch/events_handle_test.go | Adds coverage for handleEvent graph updates on WRITE/REMOVE and gitignore early return. |
| watch/events_debounce_test.go | Adds coverage for minimum prune window behavior in newEventDebouncer. |
| .github/workflows/ci.yml | Raises enforced total Go coverage floor from 45.0 to 50.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
52
to
55
| # Current enforced coverage floor. Codex PRs raise this incrementally toward 90%. | ||
| min=45.0 | ||
| min=50.0 | ||
| awk -v t="$total" -v m="$min" 'BEGIN { | ||
| if (t+0 < m+0) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.