Take into account size of function definition when formatting return type#919
Draft
JohnnyMorganz wants to merge 5 commits intomainfrom
Draft
Take into account size of function definition when formatting return type#919JohnnyMorganz wants to merge 5 commits intomainfrom
JohnnyMorganz wants to merge 5 commits intomainfrom
Conversation
…mprove-function-return-type-formatting
Contributor
Repo Comparison Testdiff --git ORI/CorePackages/modules/Collections/src/Array/map.lua ALT/CorePackages/modules/Collections/src/Array/map.lua
index 01b1443..88535aa 100644
--- ORI/CorePackages/modules/Collections/src/Array/map.lua
+++ ALT/CorePackages/modules/Collections/src/Array/map.lua
@@ -24,7 +24,9 @@ type callbackFnWithThisArg<T, U, V> = (thisArg: V, element: T, index: number, ar
-- Implements Javascript's `Array.prototype.map` as defined below
-- https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/map
-return function<T, U, V>(t: Array<T>, callback: callbackFn<T, U> | callbackFnWithThisArg<T, U, V>, thisArg: V?): Array<U>
+return function<T, U, V>(t: Array<T>, callback: callbackFn<T, U> | callbackFnWithThisArg<T, U, V>, thisArg: V?): Array<
+ U
+>
if _G.__DEV__ then
if typeof(t) ~= "table" then
error(string.format("Array.map called on %s", typeof(t)))
|
Owner
Author
|
Not a very nice diff. Need to solve that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the shape before formatting return type
Closes #896