Update wasm-bindgen and wasm-pack#908
Closed
mtoohey31 wants to merge 1 commit intoJohnnyMorganz:mainfrom
Closed
Conversation
| npx wasm-pack@0.10.3 build --target web --out-dir wasm/stylua.web -- --features lua52,lua53,lua54,luau | ||
|
|
||
| # workaround for bundler usage | ||
| echo "export { getImports as __getImports, finalizeInit as __finalizeInit }" >> wasm/stylua.web/stylua_lib.js |
Owner
There was a problem hiding this comment.
How come we are removing this line?
Author
There was a problem hiding this comment.
Good question, now that you mention this I've realized that other files in the parent directory seem to depend on these exports. The issue is the file which is generated by the latest version of wasm-pack doesn't contain getImports or finalizeInit. I'm not exactly clear on what these were actually for though...
So I've converted this to a draft for now. I'm kinda busy right now so it might be a little bit before I can dig into this and figure out what those were for.
Owner
|
Potentially this is now fixed after #1060? |
Author
|
Looks like it is, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe this should resolve the wasm-related errors I mentioned in #888. My specific project appears to work correctly after these changes. Other than building the code and using it my project though, I haven't tested anything else, so lmk if there's anything else I need to check. Thanks!
Closes #888.