SimpleRetryHandler - sleep now uses CancellationToken

[ColinBradley]

Hope this is okay!
closes #1031

[ColinBradley]

Actually, I've just noticed that this is a very minor breaking change, as previous method groups that are passed in could have an overload that took in a cancellation token, so it becomes ambiguous with the new overload on SimpleRetryHandler. It'd be a silly situation to get into, but Task.Delay is just one such example! That's why the code uses a named parameter to get around the ambiguity.

Booo C#!

So, I guess it's either: allow the minor breaking change or don't overload the constructor and instead set the sleeper with a method or something? But that seems a bit mad?

[JohnnyCrazy]

Hi,

Thanks for that, looks like a good change to have!

Could you rebase your changes on the latest master so we can get the CI to pass? LGTM then!

[ColinBradley]

Cool! All done.