Add group role and aria-labeledby attribute to groups.#6087
Open
tlfdev wants to merge 1 commit intoJedWatson:masterfrom
Open
Add group role and aria-labeledby attribute to groups.#6087tlfdev wants to merge 1 commit intoJedWatson:masterfrom
tlfdev wants to merge 1 commit intoJedWatson:masterfrom
Conversation
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am a native screen reader user. The groups example on the start page do not present the groups to the screen reader. Because groups are essentially div elements, they do not have the proper role, nor do they have the proper label.
In this fix, I assigned an ID if no ID existed to the group heading label. Then I used that ID to populate the aria-labeledby attribute. The secondary fix was to add a role of group to the div, so that screen readers and the accessibility tree know that the div is a group.
Now when navigating through this combobox, I hear the group heading as I arrow to an item in that group with the number of items in the group. This is proper and expected behavior.