feat(menu): add openMenuOnArrows option to allow disabling arrow keys to open the menu#5969
Open
Julusian wants to merge 1 commit intoJedWatson:masterfrom
Open
feat(menu): add openMenuOnArrows option to allow disabling arrow keys to open the menu#5969Julusian wants to merge 1 commit intoJedWatson:masterfrom
openMenuOnArrows option to allow disabling arrow keys to open the menu#5969Julusian wants to merge 1 commit intoJedWatson:masterfrom
Conversation
🦋 Changeset detectedLatest commit: 9fc4833 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
…ys to open the menu
Julusian
force-pushed
the
feat/open-menu-on-arrows
branch
from
25fe143 to
9fc4833
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an option to disable opening the menu when
ArrowUpandArrowDownkey events are received, defaulting to the current behaviourI am using this library in a project where the text input field is a multi-line text box.
There is quite a bit of custom logic going on, as the dropdown is really being used as suggestions for token completion, so most of the time is closed while the field has focus, and the list of options is empty.
This library is consuming the 'ArrowUp' and 'ArrowDown' key presses, to open the dropdown to the first/last values. For my use case this doesn't make sense, and simply results in those keys not working in the multi-line input field, and the menu doesn't even show.