Fix unspecific and unstable logic on control mouse down#5851
Open
mdo2 wants to merge 2 commits intoJedWatson:masterfrom
Open
Fix unspecific and unstable logic on control mouse down#5851mdo2 wants to merge 2 commits intoJedWatson:masterfrom
mdo2 wants to merge 2 commits intoJedWatson:masterfrom
Conversation
This is intended to be a temporal fix, as I think a better solution must be developed. Referenced issues: JedWatson#5833, JedWatson#5176 Another PRs abaout this: JedWatson#5842
🦋 Changeset detectedLatest commit: 3cde18e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3cde18e:
|
mdo2
force-pushed
the
fix/avoid-prevent-default
branch
from
7a706e6 to
3cde18e
Compare
Author
|
@lukebennett88, @emmatown, sorry for bothering you, but can you review this small fix? This issue is blocking my team and many others. Also, there exist two issues, at least complaining about this behavior. I appreciate any help you can provide. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use internal member to check if control onMouseDown should act and remove logic to bail out from an event if someone else listening to the event (usually in a capture phase) has called
preventDefault().This fixes interop between react-select and react-beautiful-dnd.
This is intended to be a temporal fix, as a better solution must be developed.
Closes #5833, #5176
Another PR about this: #5842