Fix ctype conversions#12
Merged
JeanExtreme002 merged 2 commits intoJeanExtreme002:masterfrom Jun 30, 2025
Merged
Conversation
Contributor
Author
|
There might be more to this I think, the search functions may also need to be fixed. |
Contributor
Author
|
Okay tested a few more times to find specific byte strings in a process and it seems fine. |
Owner
|
Hi @cromachina! Sorry for the delay in getting back to you. Thanks a lot for your contribution to the PR — really appreciate your help and your patience! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes allowing you to read 32 bit floats from the target process. Only 64 bit floats were being converted before.
This should fix #6 and #8
Fixes bytes being properly converted from the ctype buffer. Before, attempting to get bytes from
data.valuewould truncate the data like a null terminated string. According to the python docs, you should callbytes(data)to retrieve the entire buffer as bytes, examples here: https://docs.python.org/3/library/ctypes.html#ctypes.create_string_bufferI think this fixes #7, #9, and #11