Extend API v10 #57
Merged
Extend API v10 #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request extends the API for version 10 by migrating test assertions from JUnit to AssertJ and adding new dictionary methods (putIfAbsent and conditional remove).
Changes:
- Migrated all test assertions from
org.junit.jupiter.api.Assertionsto AssertJ's fluent API across 40+ test files - Added
putIfAbsent(key, value)method to MutableRefToRefDictionary, MutableLongToRefDictionary, and MutableIntToRefDictionary interfaces and implementations - Added
remove(key, expectedValue)method to the same dictionary interfaces and implementations for conditional removal - Bumped version from 10.0.alpha10 to 10.0.alpha11
Reviewed changes
Copilot reviewed 50 out of 51 changed files in this pull request and generated 18 comments.
Show a summary per file
| File | Description |
|---|---|
| build.gradle | Version bump to 10.0.alpha11 |
| README.md | Updated version reference in documentation |
| rlib-collections/.../MutableRefToRefDictionary.java | Added putIfAbsent and conditional remove method signatures |
| rlib-collections/.../MutableLongToRefDictionary.java | Added putIfAbsent and conditional remove method signatures |
| rlib-collections/.../MutableIntToRefDictionary.java | Added putIfAbsent and conditional remove method signatures |
| rlib-collections/.../AbstractMutableHashBasedRefToRefDictionary.java | Implemented putIfAbsent and conditional remove methods |
| rlib-collections/.../AbstractMutableHashBasedLongToRefDictionary.java | Implemented putIfAbsent and conditional remove methods |
| rlib-collections/.../AbstractMutableHashBasedIntToRefDictionary.java | Implemented putIfAbsent and conditional remove methods |
| rlib-collections/.../MutableRefToRefDictionaryTest.java | Added tests for new dictionary methods |
| rlib-collections/.../MutableLongToRefDictionaryTest.java | Added tests for new dictionary methods |
| rlib-collections/.../MutableIntToRefDictionaryTest.java | Added tests for new dictionary methods |
| All test files (40+ files) | Migrated assertions from JUnit to AssertJ |
...va/javasabr/rlib/collections/dictionary/impl/AbstractMutableHashBasedRefToRefDictionary.java
Outdated
Show resolved
Hide resolved
...va/javasabr/rlib/collections/dictionary/impl/AbstractMutableHashBasedIntToRefDictionary.java
Outdated
Show resolved
Hide resolved
...va/javasabr/rlib/collections/dictionary/impl/AbstractMutableHashBasedRefToRefDictionary.java
Outdated
Show resolved
Hide resolved
...a/javasabr/rlib/collections/dictionary/impl/AbstractMutableHashBasedLongToRefDictionary.java
Outdated
Show resolved
Hide resolved
...ollections/src/main/java/javasabr/rlib/collections/dictionary/MutableRefToRefDictionary.java
Outdated
Show resolved
Hide resolved
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
This pull request extends the API for version 10 by migrating test assertions from JUnit to AssertJ and adding new dictionary methods (putIfAbsent and conditional remove).
Changes:
org.junit.jupiter.api.Assertionsto AssertJ's fluent API across 40+ test filesputIfAbsent(key, value)method to MutableRefToRefDictionary, MutableLongToRefDictionary, and MutableIntToRefDictionary interfaces and implementationsremove(key, expectedValue)method to the same dictionary interfaces and implementations for conditional removal