fix(core): reset error baseline after filtering YooAsset catalog errors #610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BuildManager was incorrectly detecting false positive errors during step 4/4 (GeneratePolymorphicCodes) because the error count baseline was not reset after step 3/4 filtered out known YooAsset catalog errors. The YooAsset PreprocessBuildCatalog throws "Object reference not set" when CatalogTools.CreateCatalogFile is called with null decryption services during HybridCLR's GenerateAll step. This error is correctly filtered by CheckForErrorsExcluding, but subsequent steps still saw the elevated error count. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: JasonXuDeveloper - 傑 <jason@xgamedev.net>
There was a problem hiding this comment.
Pull request overview
This PR fixes a false positive error detection bug in the BuildManager where step 4/4 (GeneratePolymorphicCodes) incorrectly fails due to known YooAsset catalog errors from step 3/4 that were already filtered and handled.
Changes:
- Resets the error count baseline (
_errorCountAtStart) after step 3/4 filters out known YooAsset catalog errors - Prevents subsequent build steps from seeing filtered errors as new failures
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Unity Test Results✅ EditMode: All tests passed Unity Version: 2022.3.55f1 ✅ All tests passed! The PR is ready for review. View workflow run |
The Settings.json for Unity Code Coverage is only used for local development. CI uses its own coverageOptions in the workflow file, so this file doesn't need to be tracked. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: JasonXuDeveloper - 傑 <jason@xgamedev.net>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #610 +/- ##
===========================================
+ Coverage 42.84% 85.02% +42.17%
===========================================
Files 38 60 +22
Lines 4250 7684 +3434
===========================================
+ Hits 1821 6533 +4712
+ Misses 2429 1151 -1278
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
_errorCountAtStartafter step 3/4 filters out known YooAsset catalog errorsProblem
The YooAsset
PreprocessBuildCatalogthrows "Object reference not set to an instance of an object" whenCatalogTools.CreateCatalogFileis called withnulldecryption services during HybridCLR'sGenerateAllstep. While step 3/4 correctly usesCheckForErrorsExcludingto filter this known error, the error count baseline was never reset, causing step 4/4'sCheckForErrorsto still see the elevated error count and throw a false positive failure.Test plan
🤖 Generated with Claude Code