feat: add Login page; remove welcome landing page #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move login functionality from Home component to dedicated Login page - Add redirect logic for already-authenticated users - Update default next URL to /browse (from /fg/browse) - Preserve next parameter handling for post-login redirects
- Remove old getBasename() function and basename prop - stale code from JupyterHub integration - Add RootRedirect component for safe auth-based navigation - Update RequireAuth redirect to /login (from /fg/) - Restructure routes: root redirects, /login for auth, /browse protected - Add Login route and update all paths to remove /fg/ prefix
- Home login functionality is now in Login component - Update ProfileMenu login URL from /fg/ to /login
- also need to add env vars to disable access flags and okta auth
neomorphic
approved these changes
Dec 16, 2025
Member
neomorphic
left a comment
neomorphic
left a comment
There was a problem hiding this comment.
Looks good to me. Tested with the update to fileglancer-hub and it works well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clickup id: 86adnk5ya
This PR adds a dedicated login page at
/login. If the user is authenticated, they get rerouted to/browse. The base path/fg/, a holdover from when the app was served by JupyterLab, is removed.This PR should be implemented in conjunction with PR 11 fileglancer-hub.
@krokicki