New GUI Tiles#192
Open
DXCanas wants to merge 3 commits intoJaapvanEkris:0.9.7-(under-construction)from
Open
Conversation
Resolves JaapvanEkris#180 - Add `drivePeakHandleForce` property to APP_STATE - Add `peakForce` metric to DASHBOARD_METRICS with Newton (N) unit display - Format peak force value using formatNumber helper
- Add `strokeRatio` metric to DASHBOARD_METRICS - Calculate ratio from drive and recovery durations as `1:x` format
Owner
|
Great, thanks! Please name it Peak Force, as there also is an Average Force during the stroke. And indeed, ratio is a very good one to add! |
Author
|
Done! I didn't want to be the one to add the longest string per char in the set 🤪 
|
| displayName: 'Stroke Ratio', | ||
| size: 1, | ||
| template: (metrics) => { | ||
| const ratio = metrics?.driveDuration && metrics?.recoveryDuration |
Owner
There was a problem hiding this comment.
Please check if driveduration is bigger than 0, to prevent any divisions by zero in the GUI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First is the peak force metric, as described in #180 / #170
Second is a new metric that came up in my club recently; thought it was an interesting metric that could replace 2 tiles with one for those interested in it: Stroke ratio. Lots of caveats there but something interesting to train for on the erg between water sessions.