Skip to content

Add scrolling to cpu util table#1105

Merged
spirali merged 1 commit into
It4innovations:mainfrom
Dym03:ScrollCpuView
May 18, 2026
Merged

Add scrolling to cpu util table#1105
spirali merged 1 commit into
It4innovations:mainfrom
Dym03:ScrollCpuView

Conversation

@Dym03
Copy link
Copy Markdown
Contributor

@Dym03 Dym03 commented May 16, 2026

For bigger nodes with higher number of cpus, there might an overflow in the cpu util table. Scrolling through it handles it.
Current implementation has 2 flaws, but i think that handling them is not worth it, but let me know, the first one can be handled easily, second one could, but it wouldn't be clean I think.
Flaws:

  • 1 Wrapping of the scroll is handeled only in the way upward. Wrapping of downward selection would require storing the number of visible_cpus or rewriting the table to use the StatefulTable but i wasn't fond of this solution by the first glance.
  • 2 Right now scrolling is enabled even if it isn't needed. Solving this would require calculating how many cpus can be viewed on the screen.

@spirali spirali self-requested a review May 18, 2026 15:23
Copy link
Copy Markdown
Collaborator

@spirali spirali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Both are just minor things. Thank you!

@spirali spirali merged commit 07f7134 into It4innovations:main May 18, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants