Skip to content

data_sync added to journal flushing #1068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spirali merged 1 commit into from
Feb 25, 2026
Merged

data_sync added to journal flushing #1068

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions crates/hyperqueue/src/server/event/journal/write.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,11 +65,14 @@ impl JournalWriter {

pub fn flush(&mut self) -> anyhow::Result<()> {
self.file.flush()?;
/* Flush does not call file sync. We want to be sure that data
is written, especially on NFS.
*/
self.file.get_ref().sync_data()?;
Ok(())
}

pub fn finish(mut self) -> anyhow::Result<()> {
self.file.flush()?;
Ok(())
self.flush()
}
}
Loading