Skip to content

Conversation

@Kobzol
Copy link
Member

@Kobzol Kobzol commented Dec 18, 2025

WIP, doesn't have tests or documentation tests. Also I'm not sure if this makes more sense on the worker or the task (or both?).

Related issue: #1038

@Kobzol Kobzol marked this pull request as draft December 18, 2025 13:21
@spirali
Copy link
Collaborator

spirali commented Dec 18, 2025

LGTM

I have the following commets:

  • Propagation policy should be a property of a task (because of our philosophy that worker is a "provider" and task a "consumer" who chooses what it needs from a worker).
  • I would add third option "StripManager" that strips all SLURM_ and PBS_ variables
  • Question is what should be default. I would vote for "isolate" or "strip manager" as it is less surprising option than "propage", despite both are breaking changes (StripManager would probably break only a few codes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants