AxoSequencer: fix step-timeout alarm not falling after timeout clears#1160
Open
PTKu wants to merge 1 commit into
Open
AxoSequencer: fix step-timeout alarm not falling after timeout clears#1160PTKu wants to merge 1 commit into
PTKu wants to merge 1 commit into
Conversation
…GELOG for version 0.56.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AxoStepTimedOutMessenger.Activatenow resolves_contextand refreshesActiveContextCount := _context.OpenCycleCount()on every cycle the messenger stays non-Idle, restoring the standardAxoMessengerfall semantics — the step-timeout alarm previously stayed stuck active after the sequencer left the timed-out step.Run(IAxoObject)override onAxoSequenceras a placeholder site for the per-cycle_msgStepTimedOut.Serve(THIS)wiring (currently commented).GitVersion.ymlnext-version0.56.1 → 0.56.2; matching### 0.56.2entries appended to bothsrc/core/docs/CHANGELOG.mdand the centralCHANGELOG.md.Test plan
/core/AxoSequencershowcase scenario: trigger a step timeout, confirm_msgStepTimedOutrises with the step description.AggregateMessage(1)count returns to the pre-rise value after the alarm falls.apax ibinsrc/core/ctrl) and runAXOpen.Core.Teststo confirm no regression in the existing sequencer / messenger tests.next-version: 0.56.2inGitVersion.ymlmatches the latest### 0.56.2heading in both CHANGELOGs.🤖 Generated with Claude Code