Skip to content

ChainSync Timeouts#5256

Merged
coot merged 1 commit intomainfrom
edgr/chainsync-timeouts
Jan 14, 2026
Merged

ChainSync Timeouts#5256
coot merged 1 commit intomainfrom
edgr/chainsync-timeouts

Conversation

@the-headless-ghost
Copy link
Copy Markdown
Contributor

@the-headless-ghost the-headless-ghost commented Dec 4, 2025 •
edited
Loading

Description

Closes #5250.

Checklist

Quality

  • Commit sequence makes sense and have useful messages, see ref.
  • New tests are added and existing tests are updated.
  • Self-reviewed the PR.

Maintenance

  • Linked an issue or added the PR to the current sprint of ouroboros-network project.
  • Added labels.
  • Updated changelog files.
  • The documentation has been properly updated, see ref.

@the-headless-ghost the-headless-ghost self-assigned this Dec 4, 2025
@github-project-automation github-project-automation Bot moved this to In Progress in Ouroboros Network Dec 4, 2025
the-headless-ghost
the-headless-ghost commented Dec 5, 2025
View reviewed changes
Comment thread cardano-diffusion/framework/lib/Cardano/Network/Driver/Limits.hs Outdated
coot
coot reviewed Dec 5, 2025
View reviewed changes
Comment thread cardano-diffusion/api/lib/Cardano/Network/Protocol/Limits.hs Outdated
Comment thread cardano-diffusion/framework/lib/Cardano/Network/Driver/Limits.hs Outdated
Comment thread cardano-diffusion/framework/lib/Cardano/Network/Driver/Limits.hs Outdated
Comment thread cardano-diffusion/protocols/lib/Cardano/Network/Protocol/ChainSync/Codec/TimeLimits.hs
coot
coot reviewed Dec 5, 2025
View reviewed changes
Comment thread dmq-node/src/DMQ/NodeToNode.hs Outdated
Comment thread ouroboros-network/framework/lib/Ouroboros/Network/Context.hs
the-headless-ghost
the-headless-ghost commented Dec 8, 2025
View reviewed changes
Comment thread cardano-diffusion/lib/Cardano/Network/NodeToNode.hs Outdated
@the-headless-ghost the-headless-ghost force-pushed the edgr/chainsync-timeouts branch 2 times, most recently from 920f7fa to 6f493ea Compare December 11, 2025 05:24
the-headless-ghost
the-headless-ghost commented Dec 11, 2025
View reviewed changes
Comment thread docs/network-spec/miniprotocols.tex Outdated
@the-headless-ghost the-headless-ghost marked this pull request as ready for review December 18, 2025 07:29
@the-headless-ghost the-headless-ghost requested a review from a team as a code owner December 18, 2025 07:29
@crocodile-dentist
Copy link
Copy Markdown
Contributor

crocodile-dentist commented Dec 18, 2025

If you rebase on master, the dmq-node related patches should be removed as it is no longer part of this repo.

@the-headless-ghost the-headless-ghost force-pushed the edgr/chainsync-timeouts branch 2 times, most recently from edc6ab2 to a40b14a Compare January 7, 2026 11:02
coot
coot approved these changes Jan 9, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few readability suggestions which are worth to consider.

Comment thread cardano-diffusion/protocols/lib/Cardano/Network/Protocol/ChainSync/Codec/TimeLimits.hs Outdated
Comment thread ...no-diffusion/protocols/tests-lib/Cardano/Network/Protocol/ChainSync/Codec/TimeLimits/Test.hs Outdated
Comment thread ouroboros-network/changelog.d/20251211_124142_edgr_chainsync_timeouts.md Outdated
Comment thread ouroboros-network/lib/Ouroboros/Network/PeerSelection/Governor/EstablishedPeers.hs Outdated
Comment thread ouroboros-network/lib/Ouroboros/Network/PeerSelection/Governor/ActivePeers.hs Outdated
@the-headless-ghost the-headless-ghost force-pushed the edgr/chainsync-timeouts branch 2 times, most recently from 7bee2bd to 522c500 Compare January 12, 2026 12:33
@the-headless-ghost
Refactor: Move timeLimitsChainSync and add extraFlag type variables
ad29b46 
- Move timeLimitsChainSync to Cardano.Network.Protocol.ChainSync.Codec.TimeLimits
- Add PeerTrustable parameter to timeLimitsChainSync and adjust timeout behavior for trusted peers
- Bump minChainSyncTimeout to 601 and maxChainSyncTimeout to 911
- Add extraFlag type variable to various contexts and handles for extensibility
- Add extraFlags parameter to peer selection and connection management functions
- Add property tests for timeLimitsChainSync timeout validation
@coot coot added this pull request to the merge queue Jan 14, 2026
Merged via the queue into main with commit 5c318f7 Jan 14, 2026
599 of 612 checks passed
@coot coot deleted the edgr/chainsync-timeouts branch January 14, 2026 21:04
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Ouroboros Network Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coot coot coot approved these changes

Assignees

@the-headless-ghost the-headless-ghost

Labels

chain-sync

Projects

Ouroboros Network
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ChainSync Timeouts for trustable peers

3 participants

@the-headless-ghost @crocodile-dentist @coot