Skip to content

Prepare for wasm#5229

Merged
coot merged 10 commits intoIntersectMBO:mainfrom
palas:prepare-for-wasm
Jan 14, 2026
Merged

Prepare for wasm#5229
coot merged 10 commits intoIntersectMBO:mainfrom
palas:prepare-for-wasm

Conversation

@palas
Copy link
Copy Markdown
Contributor

@palas palas commented Oct 20, 2025

Description

This PR patches the parts of ouroboros-network that make compilation fail for wasm. I have done two commits, because of the decision to undo removal of "deprecation warnings", in case we reconsider, but let's squash before merging.

Checklist

Quality

  • Commit sequence makes sense and have useful messages, see ref.
  • New tests are added and existing tests are updated.
  • Self-reviewed the PR.

Maintenance

  • Linked an issue or added the PR to the current sprint of ouroboros-network project.
  • Added labels.
  • Updated changelog files.
  • The documentation has been properly updated, see ref.

@palas palas self-assigned this Oct 20, 2025
@palas palas requested a review from a team as a code owner October 20, 2025 23:48
@palas palas added the maintenance Issues / PRs related to maintenance of any of the compoents. label Oct 20, 2025
@github-project-automation github-project-automation Bot moved this to In Progress in Ouroboros Network Oct 20, 2025
@coot
Copy link
Copy Markdown
Collaborator

coot commented Oct 21, 2025

Could you add a cross compilation target to wasm using nix? Otherwise, sooner or later it will get broken. This could answer the first question :).

@palas
Copy link
Copy Markdown
Contributor Author

palas commented Oct 21, 2025

Could you add a cross compilation target to wasm using nix? Otherwise, sooner or later it will get broken. This could answer the first question :)

I don't now how to do it with haskell.nix yet, I'll ask if it is possible. So far, I made a GHA job in cardano-api but it involves some more conditional SRPs for dependencies and some extra nix code for libraries with C bindings. We have it non-required so that it is a warning but doesn't disturb the development.

@palas palas requested a review from a team as a code owner October 24, 2025 01:39
@palas palas requested a review from coot October 27, 2025 13:18
@palas palas moved this from In Progress to In Review in Ouroboros Network Nov 4, 2025
Copy link
Copy Markdown
Collaborator

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor comments.

Comment thread cardano-diffusion/lib/Cardano/Network/NodeToNode.hs
Comment thread network-mux/src/Network/Mux/Channel.hs Outdated
Comment thread ouroboros-network/demo/connection-manager.hs Outdated
Comment thread ouroboros-network/framework/lib/Ouroboros/Network/Snocket.hs Outdated
Comment thread ouroboros-network/framework/lib/Ouroboros/Network/Snocket.hs Outdated
Comment thread ouroboros-network/tests/io/Test/Ouroboros/Network/Socket.hs Outdated
@coot coot enabled auto-merge January 14, 2026 20:24
@coot coot added this pull request to the merge queue Jan 14, 2026
Merged via the queue into IntersectMBO:main with commit 93d8c6b Jan 14, 2026
401 of 403 checks passed
@github-project-automation github-project-automation Bot moved this from In Review to Done in Ouroboros Network Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Issues / PRs related to maintenance of any of the compoents.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants