fix: use Conway maxRefScriptSizePerTx limit 204,800 bytes (200 KiB)#185
Open
danbaruka wants to merge 1 commit intoIntersectMBO:mainfrom
Open
fix: use Conway maxRefScriptSizePerTx limit 204,800 bytes (200 KiB)#185danbaruka wants to merge 1 commit intoIntersectMBO:mainfrom
danbaruka wants to merge 1 commit intoIntersectMBO:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
calculateReferenceScriptFeeinTxBuilderImpl.tswas rejecting transactions whose total reference script size exceeded 200,000 bytes. The Conway-era hard cap is 204,800 bytes (200 × 1024 = 200 KiB). Transactions with total reference script size between 200,001 and 204,800 bytes were incorrectly rejected by the SDK but accepted by the node.Closes #178
Root cause
The check used a literal
200_000instead of the ledger constant200 * 1024:if (totalScriptSize > 200_000)if (totalScriptSize > 204_800)Source: Conway ledger
ppMaxRefScriptSizePerTxG = 200 * 1024(ConwayEraPParams, ADR-009). This becomes a protocol parameter in Dijkstra era (ppMaxRefScriptSizePerTxL).Changes
packages/evolution/src/sdk/builders/TxBuilderImpl.ts(calculateReferenceScriptFee):200_000to204_800.