Add message validation tracer #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crocodile-dentist
force-pushed
the
mw/validation-tracing
branch
from
9438a2b to
cef8afd
Compare
coot
approved these changes
Dec 23, 2025
| dmqcLocalServerTracer = I False, | ||
| dmqcLocalInboundGovernorTracer = I False, | ||
| dmqcDnsTracer = I False, | ||
| dmqcValidationTracer = I False, |
Contributor
There was a problem hiding this comment.
It should be on by default, we don't expect many invalid messages, and once it happen the connection is closed, so we won't be flooded by them.
Suggested change
| dmqcValidationTracer = I False, | |
| dmqcValidationTracer = I True, |
Comment on lines
+188
to
+189
| instance Show (Sig crypto) where | ||
| show Sig { sigId } = "Sig crypto ... " <> show sigId |
Contributor
There was a problem hiding this comment.
We shouldn't use Show for, could you just leave a TODO for adding a Display type class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes
Traces reasons for signature validation failure
Checklist