Fix CI #2
Merged
Fix CI #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crocodile-dentist
force-pushed
the
mw/docker-images
branch
2 times, most recently
from
54e9146 to
5afb292
Compare
crocodile-dentist
force-pushed
the
mw/docker-images
branch
17 times, most recently
from
7c7845d to
662b4a6
Compare
coot
reviewed
Dec 17, 2025
Comment on lines
30
to
47
| steps: | ||
| - name: Waiting for ci/hydra-build:required to complete | ||
| run: | | ||
| while [[ true ]]; do | ||
| check_name='ci/hydra-build:required' | ||
| conclusion=$(gh api "repos/$GITHUB_REPOSITORY/commits/$GITHUB_SHA/check-runs?check_name=$check_name" --paginate --jq '.check_runs[].conclusion') | ||
| case "$conclusion" in | ||
| success) | ||
| echo "$check_name succeeded" | ||
| exit 0;; | ||
| '') | ||
| echo "$check_name pending. Waiting 30s..." | ||
| sleep 30;; | ||
| *) | ||
| echo "$check_name terminated unsuccessfully" | ||
| exit 1;; | ||
| esac | ||
| done |
Contributor
There was a problem hiding this comment.
🤔 we could use something similar to download cross compilation build artifacts in ouroboros-network.
Contributor
Author
There was a problem hiding this comment.
This is to build the docker image, what what be the use case in ouroboros-network?
Contributor
There was a problem hiding this comment.
Download test artefacts and run them on native Windows machines (they don't run on Wine, and even if they did, it's not good enough).
crocodile-dentist
force-pushed
the
mw/docker-images
branch
2 times, most recently
from
014c858 to
7157091
Compare
crocodile-dentist
force-pushed
the
mw/docker-images
branch
3 times, most recently
from
1ae3cc4 to
b34b404
Compare
crocodile-dentist
force-pushed
the
mw/docker-images
branch
3 times, most recently
from
046c93e to
a0c59d7
Compare
coot
approved these changes
Dec 19, 2025
crocodile-dentist
force-pushed
the
mw/docker-images
branch
4 times, most recently
from
f7a471e to
953f98d
Compare
Add CI work flows Formatting
crocodile-dentist
force-pushed
the
mw/docker-images
branch
from
953f98d to
290e7d8
Compare
crocodile-dentist
force-pushed
the
mw/docker-images
branch
from
290e7d8 to
91abf6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes
Checklist