trace-resources: remove local package, use hermod-trace-resources from hermod-tracing#6603
Draft
jutaro wants to merge 2 commits into
Draft
trace-resources: remove local package, use hermod-trace-resources from hermod-tracing#6603jutaro wants to merge 2 commits into
jutaro wants to merge 2 commits into
Conversation
cabal.project: removed trace-resources local package, added source-repository-package pointing to hermod-tracing@f94edf21 flake.nix: added hermod-tracing flake input (branch without_contra_included) nix/haskell.nix: added hermod-tracing to function args and inputMap, renamed "trace-resources" → "hermod-trace-resources" in profiled builds 4 dependent cabal files: trace-resources → hermod-trace-resources 12 Haskell source files: all Cardano.Logging.Resources imports → Hermod.Tracing.Resources stylish-haskell.yml: removed trace-resources entry GhciSchemaGen.hs: updated path to ../hermod-tracing/hermod-trace-resources/src
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the trace-resources local package from this repository. It now lives in IntersectMBO/hermod-tracing as hermod-trace-resources, alongside the trace-dispatcher package it depends on.
All import sites are updated to the new Hermod.Tracing.Resources.* module namespace.
Nix builds resolve the package via the hermod-tracing flake input and inputMap in nix/haskell.nix. A source-repository-package stanza in cabalProjectLocal (nix-only, never read by plain cabal) pins the commit. Plain cabal builds require a cabal.project.local entry pointing to a local checkout (see below); this will be dropped once hermod-trace-resources is published to CHaP.
Changes
Deleted: trace-resources/ directory (entire package)
cabal.project: remove trace-resources local package; add note about cabal.project.local for local cabal builds
flake.nix: add hermod-tracing flake input
nix/haskell.nix: add hermod-tracing to inputMap; move source-repository-package stanza into cabalProjectLocal (nix-only); rename "trace-resources" → "hermod-trace-resources" in profiled build list
4 .cabal files (cardano-node, cardano-tracer, locli, cardano-timeseries-io): trace-resources → hermod-trace-resources dependency
12 Haskell source files: Cardano.Logging.Resources.* imports → Hermod.Tracing.Resources.*
bench/trace-schemas/scripts/schema-gen/GhciSchemaGen.hs: update source path
.github/workflows/stylish-haskell.yml: remove trace-resources entry
nix develop --override-input hermod-tracing
"git+file:///path/to/hermod-tracing?rev=f94edf21d7df01f43e115e370f0a48fd00240003"