Skip to content

cardano-testnet | Refactor getEpochStateDetails to return immediately on foldEpochState` failure.#6525

Open
carbolymer wants to merge 1 commit intomasterfrom
mgalazyn/refactor/report-getepochstate-failures
Open

cardano-testnet | Refactor getEpochStateDetails to return immediately on foldEpochState` failure.#6525
carbolymer wants to merge 1 commit intomasterfrom
mgalazyn/refactor/report-getepochstate-failures

Conversation

@carbolymer
Copy link
Copy Markdown
Contributor

Extends the timeout of getEpochStateDetails, which seems to be not long enough on aarch64.

Refactor getEpochStateDetails to return immediately on foldEpochState` failure.

Change getEpochStateDetails to return a tuple instead of accepting a function.

Description

Add your description here, if it fixes a particular issue please provide a
link
to the issue.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Running tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-9.6 and ghc-9.12
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@carbolymer carbolymer self-assigned this Apr 13, 2026
@carbolymer carbolymer requested a review from a team as a code owner April 13, 2026 08:47
Copy link
Copy Markdown
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

…te failure.

Change getEpochStateDetails to return a tuple instead of accepting a function.
@carbolymer carbolymer force-pushed the mgalazyn/refactor/report-getepochstate-failures branch from 0050528 to 11603af Compare April 14, 2026 08:56
@carbolymer carbolymer enabled auto-merge April 14, 2026 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants