refactor(tests): remove unused 'total_stake' option #3207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'total_stake' option and its related code were removed from TestAdvancedQueries in test_cli.py. This includes eliminating the conditional branch, error handling, and test parameter referencing 'total_stake', as it is no longer supported by the recent cardano-cli versions.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the deprecated total_stake option from the TestAdvancedQueries test class, cleaning up code that is no longer supported by recent cardano-cli versions.
Key Changes:
- Removed the
"total_stake"conditional branch from the_check_stake_snapshotmethod - Removed the
CLIErrorexception handler that was specifically for handling the deprecated option - Removed
"total_stake"from the test parametrization intest_stake_snapshot
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'total_stake' option and its related code were removed from TestAdvancedQueries in test_cli.py. This includes eliminating the conditional branch, error handling, and test parameter referencing 'total_stake', as it is no longer supported by the recent cardano-cli versions.