Drop redundant ProtocolParametersUpdate conversion in shelleyToBabbage update

[Jimbo4350]

Changelog

- description: |
    Drop the redundant `createEraBasedProtocolParamUpdate` /
    `fromLedgerPParamsUpdate` round-trip in
    `shelleyToBabbageProtocolParametersUpdate`; pass
    `EraBasedProtocolParametersUpdate era` straight to
    `makeShelleyUpdateProposal`.
# uncomment types applicable to the change:
  type:
   - refactoring    # QoL changes
# uncomment at least one main project this PR is associated with
  projects:
   - cardano-cli

Context

makeShelleyUpdateProposal (cardano-api ^>=11.1, already required on master) accepts EraBasedProtocolParametersUpdate era directly. The existing code in shelleyToBabbageProtocolParametersUpdate constructed that value, converted it to the deprecated ProtocolParametersUpdate via createEraBasedProtocolParamUpdate / fromLedgerPParamsUpdate, then passed the result to makeShelleyUpdateProposal — an unnecessary round-trip through the old API.

No behaviour change: the function still produces the same UpdateProposal era text envelope.

How to trust this PR

• cabal build cardano-cli -j4 builds cleanly.
• Test.Cli.Compatible.Transaction.Build exercises compatible <era> governance action create-protocol-parameters-update for shelley/allegra/mary/alonzo/babbage and diffs each against a reference produced via the same code path — passing means the produced text envelope is byte-identical to before.

Checklist

• Commit sequence broadly makes sense and commits have useful messages
• New tests are added if needed and existing tests are updated. See Running tests for more details
• Self-reviewed the diff

[Copilot]

Pull request overview

This PR updates cardano-cli to match cardano-api’s removal of ProtocolParametersUpdate, switching rendering and governance flows to the era-indexed replacement while keeping the existing “friendly” JSON/YAML output shape for protocol parameter updates.

Changes:

• Bump cardano-api dependency and adjust code to use era-indexed protocol parameter update types.
• Rewrite friendlyProtocolParametersUpdate to render from ledger PParamsUpdate produced from EraBasedProtocolParametersUpdate.
• Add a golden test + fixtures to pin the YAML output shape for an Alonzo update proposal embedded in a transaction.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
flake.lock	Updates pinned CHaP revision/hash to align with dependency changes.
cabal.project	Advances CHaP index-state to pick up the newer package set.
cardano-cli/cardano-cli.cabal	Bumps cardano-api bound and adds cardano-ledger-binary dependency for version rendering.
cardano-cli/src/Cardano/CLI/Read.hs	Adds shelleyToBabbageEraConstraints to satisfy new era-indexed UpdateProposal envelope constraints.
cardano-cli/src/Cardano/CLI/Compatible/Json/Friendly.hs	Refactors protocol-parameter-update rendering to dispatch by era and emit the legacy flat key set.
cardano-cli/src/Cardano/CLI/Compatible/Governance/Run.hs	Removes a redundant conversion round-trip when building Shelley-to-Babbage update proposals.
cardano-cli/test/cardano-cli-golden/Test/Golden/TxView.hs	Adds a new golden test that generates and views an Alonzo tx with an update proposal and compares YAML output.
cardano-cli/test/cardano-cli-golden/files/input/genesis1.vkey	Adds a genesis verification key fixture used by the new golden test.
cardano-cli/test/cardano-cli-golden/files/golden/alonzo/transaction-view-update-proposal.yaml	Adds the expected YAML output for the new golden test.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[palas]

👍