-
Notifications
You must be signed in to change notification settings - Fork 1
Added Download Button implementation #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a new download button implementation to the web groups manager UI framework. The download button displays a progress bar that can show different states (not-started, in-progress, paused, finished) with corresponding visual feedback.
Changes:
- Added a new
Downloadsstandard button type with progress tracking capabilities - Integrated the downloads button into caption bars, tab bars, and HTML button bars
- Added CSS styling for download button states and progress visualization
- Updated theme package dependency from 3.1.0 to ^3.2.0
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 15 comments.
Show a summary per file
| File | Description |
|---|---|
| src/webGroupsManager.ts | Added onDownloadsButtonClick handler method |
| src/types/internal.ts | Added downloadsState to ButtonProps and CreateStandardButtonsOptions, added Downloads enum value |
| src/types/defaultComponents.ts | Added DownloadsButtonProps interface and downloads button to button collections |
| src/types/api.ts | Added downloads button prop to API interfaces |
| src/defaultComponents/utils/common.ts | Added utility function for download button class name generation |
| src/defaultComponents/htmlButtonsBar/buttons.tsx | Integrated downloads button into HTML buttons bar |
| src/defaultComponents/flatCaptionBar/FlatButtons.tsx | Integrated downloads button into flat caption bar |
| src/defaultComponents/buttons/DownloadsButton.tsx | New component implementing the downloads button with progress bar |
| src/GroupElementCreationWrapper.tsx | Added downloads button onClick handlers for Frame, TabBar, and HtmlButtons targets |
| package.json | Updated @interopio/theme dependency to ^3.2.0 |
| assets/css/vars.css | Added CSS variables for progress bar styling |
| assets/css/groups.css | Added CSS rules for download button and progress states |
Comments suppressed due to low confidence (1)
src/types/internal.ts:30
- The
isPressedproperty is already defined inButtonPropsat line 20. This creates a duplicate property definition in the interface. TheisPressedproperty should be removed from line 20 since it's being added as a new field, or this line should be removed ifisPressedwas intended to be part of the base interface.
export interface ToggleButtonProps extends ButtonProps {
isPressed: boolean;
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1,4 +1,6 @@ | |||
| import { ButtonProps } from "@interopio/components-react"; | |||
Copilot
AI
Jan 14, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The imported ButtonProps from "@interopio/components-react" is not used in this file. Only DownloadsButtonProps from the local types is used. Remove this unused import to keep the code clean.
| import { ButtonProps } from "@interopio/components-react"; |
No description provided.