[Refactor] Move float8_handler initialization from TrainEngine to BaseModel#1517
Open
HAOCHENYE wants to merge 2 commits intogh/HAOCHENYE/17/basefrom
Open
[Refactor] Move float8_handler initialization from TrainEngine to BaseModel#1517HAOCHENYE wants to merge 2 commits intogh/HAOCHENYE/17/basefrom
HAOCHENYE wants to merge 2 commits intogh/HAOCHENYE/17/basefrom
Conversation
This was referenced Mar 2, 2026
HAOCHENYE
added a commit
to HAOCHENYE/xtuner
that referenced
this pull request
Mar 2, 2026
…eModel - Remove float8_handler as a direct attribute of TrainEngine - Add float8_handler as a lazy-initialized property in BaseModel - Move Float8Handler.build() logic to Float8Config.build() - Update _maybe_precompute_float8_dynamic_scale_for_fsdp to iterate through model modules ghstack-source-id: fdad8ec Pull-Request: InternLM#1517
HAOCHENYE
added a commit
to HAOCHENYE/xtuner
that referenced
this pull request
Mar 3, 2026
…eModel - Remove float8_handler as a direct attribute of TrainEngine - Add float8_handler as a lazy-initialized property in BaseModel - Move Float8Handler.build() logic to Float8Config.build() - Update _maybe_precompute_float8_dynamic_scale_for_fsdp to iterate through model modules ghstack-source-id: fdad8ec Pull-Request: InternLM#1517
HAOCHENYE
added a commit
to HAOCHENYE/xtuner
that referenced
this pull request
Mar 3, 2026
…eModel - Remove float8_handler as a direct attribute of TrainEngine - Add float8_handler as a lazy-initialized property in BaseModel - Move Float8Handler.build() logic to Float8Config.build() - Update _maybe_precompute_float8_dynamic_scale_for_fsdp to iterate through model modules ghstack-source-id: b3e7123 Pull-Request: InternLM#1517
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
ModelOutputspydanticBaseModel#1516