Improve descriptions for some device object fields and add a new field called code
#166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Circular definitions are removed. i.e. field name is no longer used in the description. 2. Clarifies the difference between the well-known marketing name and the manufacturer's provided model code. i.e. `GLBW0` for Pixel 10. 3. Introduces the word “series” to explain the difference between `model` and `hmv` with examples to show the different values. 4. Expands the examples to include more modern devices from a broader range of vendors.
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GLBW0for Pixel 10.modelandhmvwith examples to show the different values.