Skip to content

Conversation

@Nik-Shalashov
Copy link

No description provided.

@seanheinrichs
Copy link

Thank you. I hope this gets merged as all of the samples in our repo are broken. I ported this change over to our codebase. 🚀

Copy link

@A1exKH A1exKH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

In scope of this PR:

  1. Was added new file VAST 4.0 Samples/redirect-test.xml
  2. Old links, that returned 403 AccessDenied message, were replaced for valid links on github.
    2.1. Old:
    <![CDATA[https://iab-publicfiles.s3.amazonaws.com/vast/VAST-4.0-Short-Intro.mp4]]>
    New:
    <![CDATA[https://github.com/inetra/VAST_Samples/raw/master/VAST/VAST-4.0-Short-Intro.mp4]]>
    2.2. Old:
    <![CDATA[https://iab-publicfiles.s3.amazonaws.com/vast/VAST-4.0-Short-Intro-mid-resolution.mp4]]>
    New:
    <![CDATA[https://github.com/inetra/VAST_Samples/raw/master/VAST/VAST-4.0-Short-Intro-mid-resolution.mp4]]>
    2.3. Old:
    <![CDATA[https://iab-publicfiles.s3.amazonaws.com/vast/VAST-4.0-Short-Intro-low-resolution.mp4]]>
    New:
    <![CDATA[https://github.com/inetra/VAST_Samples/raw/master/VAST/VAST-4.0-Short-Intro-low-resolution.mp4]]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants