Moving balls #666
Merged
Moving balls #666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YukumoHunter
added
enhancement
oxkitsune
requested changes
Sep 5, 2025
YukumoHunter
commented
Sep 5, 2025
Comment on lines
+274
to
+290
| .filter(|hypothesis| { | ||
| mahalanobis_distance( | ||
| measurement.position.coords, | ||
| hypothesis.position().coords, | ||
| hypothesis | ||
| .filter | ||
| .covariance() | ||
| .fixed_view::<2, 2>(0, 0) | ||
| .into_owned(), | ||
| ) | ||
| .unwrap_or_default() | ||
| < config.max_mahalonobis_association_distance | ||
| && measurement.position.coords.norm() | ||
| < config.max_euclidean_association_distance | ||
| }) |
Member
Author
There was a problem hiding this comment.
This is still sus and i want to test it more
Member
There was a problem hiding this comment.
checking both euclidean AND mahalanobis?
Member
Author
There was a problem hiding this comment.
yeah I think we want to cap the association distance since it now associates with very far away balls if we haven't seen anything in a while
YukumoHunter
force-pushed
the
harold/move-yo-balls
branch
from
c9bd77f to
9883cbb
Compare
oxkitsune
reviewed
Sep 5, 2025
oxkitsune
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screencast.From.2025-09-03.22-03-05.mp4
Screencast.From.2025-09-04.16-00-14.mp4