Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR titled "Lots of improvements" makes changes across 12 listing files spanning multiple chapters of what appears to be a C# educational codebase. However, many of these changes introduce bugs or break the intended functionality of the code examples.
Key changes:
- Modified arithmetic operations and calculations in several examples
- Changed equality comparison logic in the Equals implementation
- Altered string formatting and method calls in various demonstrations
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| Chapter12/Listing12.06 | Modified Cell constructor to add offset to X coordinate |
| Chapter11/Listing11.07 | Changed overflow demonstration from n + 1 to n + 2 |
| Chapter10/Listing10.01 | Changed equality comparison from == to != for Model field |
| Chapter09/Listing09.03 | Changed Degrees value in with expression from 180 to 181 |
| Chapter08/Listing08.02 | Changed name format from "firstName lastName" to "lastName, firstName" |
| Chapter07/Listing07.02 | Added middle initial to "Inigo Montoya" |
| Chapter06/Listing06.08 | Added exclamation mark to console output |
| Chapter05/Listing05.25 | Changed months calculation from age * 12 to age * 13 |
| Chapter05/Listing05.02 | Changed greeting from "Hey you!" to "Hello there!" |
| Chapter04/Listing04.03 | Modified remainder output to remainder + 1 |
| Chapter03/Listing03.03 | Changed method call from ToUpper to ToLower |
| Chapter02/Listing02.14 | Swapped order of firstName and lastName in output |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/Chapter10/Listing10.01.ImplementingTheEqualsAndNotEqualsOperators.cs
Show resolved
Hide resolved
17eef5a to
348be99
Compare
348be99 to
dd758ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.