fix: correct tab completion for /plot flag set <flag> <value>#4698
Open
jvstinxz wants to merge 4 commits intoIntellectualSites:mainfrom
Open
fix: correct tab completion for /plot flag set <flag> <value>#4698jvstinxz wants to merge 4 commits intoIntellectualSites:mainfrom
/plot flag set <flag> <value>#4698jvstinxz wants to merge 4 commits intoIntellectualSites:mainfrom
Conversation
Member
|
the tabcompletion should probably get a small refactor - if you want to, you can adjust those small things:
|
Contributor
Author
|
Still new to this so I just did the third suggestion, should be fine like that. |
dordsor21
reviewed
Jul 25, 2025
| .map(value -> new Command(null, false, value, "", RequiredType.NONE, null) { | ||
| }).collect(Collectors.toList()); | ||
| } else if (Arrays.asList("set", "add", "remove", "delete", "info") | ||
| } else if (Arrays.asList("set", "s", "add", "a", "remove", "r", "delete", "info", "i") |
Member
There was a problem hiding this comment.
Yeah I'd like to see these extracted to static final Collections.immutableSet at the class level - this would be best practices for Java. The args.length == # should be moved -- it is unlikely for these operations to be reordered
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #3028
Description
This PR fixes the incorrect tab completion behavior for the command
/plot flag set <flag> <value>Submitter Checklist
@since TODO.