feat: Add DisableBlockUpdateFlag#4569
feat: Add DisableBlockUpdateFlag#4569AerWyn81 wants to merge 2 commits intoIntellectualSites:mainfrom
Conversation
|
I don't know if getting this specific with block physics should be in P2? I feel like the condition for not updating blocks is quite arbitrary, and doesn't really serve much of a purpose to the plot itself, and is rather something that should be player-specific based on that player's preferences |
|
Hi @dordsor21, thanks for your response I can understand your point of view in a context other than creative. |
| "flags.flag_description_concrete_harden": "<gray>Set to `false` to disable concrete powder forming to concrete with water.</gray>", | ||
| "flags.flag_description_device_interact": "<gray>Set to `true` to allow devices to be interacted with in the plot.</gray>", | ||
| "flags.flag_description_disable_physics": "<gray>Set to `true` to disable block physics in the plot.</gray>", | ||
| "flags.flag_description_disable_block_update": "<gray>Set to `true` to disable block update in the plot.</gray>", |
There was a problem hiding this comment.
| "flags.flag_description_disable_block_update": "<gray>Set to `true` to disable block update in the plot.</gray>", | |
| "flags.flag_description_disable_block_update": "<gray>Set to `true` to disable block updates in the plot, e.g. breaking of flowers when the block below is removed.</gray>", |
| return; | ||
| } | ||
| if (!sourceBlock.getType().name().toLowerCase(Locale.ROOT).contains("snow") | ||
| || !block.getLocation().add(0, -1, 0).getBlock().getType().equals(Material.GRASS_BLOCK)) { |
There was a problem hiding this comment.
I still think this is a massively specific implementation. It should be an "all or nothing" which is why I question its inclusion; this might be how you want it, but it's not necessarily how others might want it to be implemented. This is why I suggest it might make better sense in a separate plugin where it is configurable
There was a problem hiding this comment.
For which practical creative construction use-case was this implemented? I would also say that “no block update” does not need any filter.
Description
Challenge
Using the current
disable-physicsflag doesn't suit all needs.I'm missing a flag that prevents blocks around one that I'm updating from being updated.
There are several examples:
Resolution
In this PR, I've added the
disable-block-updateflag to disable block updating when blocks are updated. The default value isfalsebecause there shouldn't be any change in the update behaviour on a plot without a flag.Two points:
disable-physicsflag because, as I see it, the two flags have their own responsibilities, one affecting the gravity of the blocks and the other the update.Submitter Checklist
@since TODO.