Skip to content

fix: StackOverflowError when binding repl tool#3538

Merged
NotMyFault merged 1 commit into
mainfrom
fix/3537
May 24, 2026
Merged

fix: StackOverflowError when binding repl tool#3538
NotMyFault merged 1 commit into
mainfrom
fix/3537

Conversation

@PierreSchwang
Copy link
Copy Markdown
Member

Overview

Fixes #3537

Submitter Checklist

  • Make sure you are opening from a topic branch (/feature/fix/docs/ branch (right side)) and not your main branch.
  • Ensure that the pull request title represents the desired changelog entry.
  • New public fields and methods are annotated with @since TODO.
  • I read and followed the contribution guidelines.

@PierreSchwang PierreSchwang requested a review from a team as a code owner May 24, 2026 07:25
Copy link
Copy Markdown
Member

@SirYwell SirYwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, in the long run we should get rid of that diff as it seems rather unnecessary in general?

@PierreSchwang
Copy link
Copy Markdown
Member Author

Most likely, yes. I would've added an override for toNaiveLin in PaperweightFaweAdapter, but that would require widening access to PaperweightAdapter#fromNative, which would be a diff as well (currently package-private).

@NotMyFault NotMyFault added the Bugfix This PR fixes a bug label May 24, 2026
@NotMyFault NotMyFault merged commit f25ded8 into main May 24, 2026
9 checks passed
@NotMyFault NotMyFault deleted the fix/3537 branch May 24, 2026 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bugfix This PR fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

/tool repl 1 - throws StackOverflowError

3 participants